Description
With the azureDatabases.confirmationStyle=challengeConfirmation prompt style the default button (responds to ⏎ Enter) is always the first number and the last number has always the focus (Space on MacOS):
I think it'd be better to make "Cancel" to always be the default.
Metadata
Metadata
Assignees
Type
Projects
Status
Done
Milestone
Relationships
Development
Participants
Activity
tnaum-ms commentedon May 21, 2025
Unfortunately, there is no way to make "Cancel" the default option, or rather - I wasn't able to find a solution here.
That's why there is a different solution in place. The first option is never the default one. The random 'confirmation' choices are always the second or the third option.
https://github.com/microsoft/vscode-cosmosdb/blob/36da7c60b77409474dce72df703f8dfe650fb8ff/src/utils/dialogs/getConfirmation.ts#L131C1-L133C1
@sevoku I'd suggest closing this issue as resolved.
We could potentially improve the comment in the code to make the maintainers aware of the reasoning behind this so that no one changes it back⚠️
tnaum-ms commentedon May 26, 2025
I added more comments to the code base.
sevoku commentedon May 26, 2025
@tnaum-ms ok I see, you're right, the first button will never be the right one, but on MacOS the last button always has the focus and can be activated with Space:
Making it a way less secure approach on MacOS if the right number is the last number. But unfortunately VS Code does not give us more control over this.
I'm fine with closing this since this is not the default option anyway, but it seems to be the default in DocumentDB?
tnaum-ms commentedon May 26, 2025
@sevoku oh, so on MacOS the default is the first button, but the selection is on the last one..
Tricky - we can do a system-dependent selection, for MacOS would it be always the index
1then?It looks like it's just no longer a good option in general and most likely should be removed. Thoughts?
8 remaining items