Skip to content

MCP Dropdown: Remove chevron focus outline #247966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hawkticehurst opened this issue May 1, 2025 · 0 comments · Fixed by #248177
Closed

MCP Dropdown: Remove chevron focus outline #247966

hawkticehurst opened this issue May 1, 2025 · 0 comments · Fixed by #248177
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug chat chat-mcp insiders-released Patch has been released in VS Code Insiders ux User experience issues
Milestone
May 2025

Comments

@hawkticehurst
Copy link
Member

hawkticehurst commented May 1, 2025 •
edited
Loading

Just noticed that when someone clicks on the chevron to open an MCP card/dropdown there's a blue focus outline that remains visible until you click on something else. We should remove this and ideally make the entire dropdown "header" have a focus outline instead.

Image Image
@hawkticehurst hawkticehurst added ux User experience issues chat chat-mcp labels May 1, 2025
@connor4312 connor4312 added the bug Issue identified by VS Code Team member as probable bug label May 1, 2025
connor4312 added a commit that referenced this issue May 5, 2025
@connor4312
tools: fix focus/click handling in tool confirmation
7f0bb28 
Make the expandable header a proper Button.

Fixes #247966
@connor4312 connor4312 mentioned this issue May 5, 2025
Merged
connor4312 added a commit that referenced this issue May 5, 2025
@connor4312
tools: fix focus/click handling in tool confirmation (#248177)
06066c5 
Make the expandable header a proper Button.

Fixes #247966
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label May 5, 2025
@vs-code-engineering vs-code-engineering bot added this to the May 2025 milestone May 5, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug chat chat-mcp insiders-released Patch has been released in VS Code Insiders ux User experience issues
Projects
None yet
Milestone
May 2025
Development

Successfully merging a pull request may close this issue.

tools: fix focus/click handling in tool confirmation microsoft/vscode
2 participants
@connor4312 @hawkticehurst