activationEvents.workspaceContains doesn't fire for directory

[flynnwt]

Is this expected? Also, a general way to detect all workspace-open events, like 'workspaceContains:*' or an onDidChangeWorkspace event would be useful.

[egamma]

Yes currently this event is only triggered for files. The Scenario is when there is a file like .editorconfig.
What is your scenario, where you want to be activated for a particular directory?

CC @alexandrudima

[flynnwt]

I initially was trying to use the fact that a directory exists to enable an extension (for backing up timestamped edits), and just using the user settings for configuration. I did add an empty file for now to trigger it. If I wanted to make the directory configurable, I would need a separate config file anyway, or a notification on any workspace opening, to check dynamically.

[egamma]

For this scenario I would tolerate using this activation event: https://code.visualstudio.com/docs/extensionAPI/activation-events#_activationevents

[flynnwt]

Thanks, I did play with that but didn't realize from the description that it occurs on every workspace open, not just initial startup. So the '*' activation does allow any kind of per-workspace checking to be done before enabling an extension.

[iambibhas]

@egamma in my case, I want the extension to activate only when current directory is a git repository. i.e. it'll have the .git/ directory in current directory. I've tried putting "workspaceContains:.git/config" but that does nothing and the commands are activated anyway. I don't think I understand how this activationEvents works. :|

[egamma]

reopening

[alexdima]

@iambibhas workspaceContains:X gets fired for all X where X is a top level file. If you open a folder in VSCode that contains:

• .git (folder)
• bla.txt (file)
• foo (file)

the following events will be fired when the folder is opened: workspaceContains:bla.txt and workspaceContains:foo

[iambibhas]

@alexandrudima so then shouldn't the activation fail if only workspaceContains:.git is present? Why does it still get activated?

[alexdima]

@iambibhas That is the actual feature request, that we fire activation events for folders too.

The code today only does so for files:
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/node/extensionHostMain.ts#L249
https://github.com/Microsoft/vscode/blob/master/src/vs/base/node/pfs.ts#L188
https://github.com/Microsoft/vscode/blob/master/src/vs/base/node/pfs.ts#L168