Skip to content

feature: Allow diagnostics messages to have markdown content #214051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 76 commits into
base: main
Choose a base branch
from

Conversation

SimonSiefke
Copy link
Contributor

fixes #54272.

This enables using markdown content in diagnostic messages. For now, the markdown messages are only rendered in the hover widget but not in the problems panel.

Testing

There is a sample diagnostic extension in extensions/sample-diagnostic-extension that uses markdown in diagnostic messages. Open the sample-demo.rs file to see the markdown diagnostics:

diagnostic-markdown-compressed.mp4

…ssages-markdown

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…lient.ts

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ots__/Response_async_content.0.snap

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ots__/Response_async_content.1.snap

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ots__/Response_content__markdown.0.snap

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ots__/Response_markdown__content.0.snap

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ots__/Response_markdown__markdown.0.snap

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@SimonSiefke SimonSiefke marked this pull request as ready for review October 1, 2024 17:25
tsc
…ssages-markdown
…ssages-markdown
…ages-markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow diagnostics messages to have markdown (or formatted text) content
2 participants