fix: ignore all node_modules and .git dirs by default #5204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Putting in draft per #5203 (comment). Sorry for being misleading! |
JoshuaKGoldberg
added
the
semver-major
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default watch-ignore patterns to recursively ignore all node_modules and .git directories, not just those at the root.
- Updated "watch-ignore" in lib/mocharc.json to use "/node_modules" and "/.git".
- Ensures that file watchers effectively skip these directories regardless of their location.
Comments suppressed due to low confidence (1)
lib/mocharc.json:9
- Consider verifying that the recursive '**/' pattern does not ignore directories that should remain watched (e.g., for debugging or testing purposes). If necessary, update the documentation to clearly communicate the change in behavior.
"watch-ignore": ["**/node_modules", "**/.git"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
--watch-ignoreto**/node_modules,**/.git#5203status: accepting prsOverview
Just adds
**/before the default ignore patterns so that allnode_modulesand.gitdirs get ignored, not just ones in the root folder.