[WIP] fix: watch mode using chokidar v4 (#5355) #5379
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glob paths are no longer supported by chokidar starting at v4.
This update works around this by resolving
watchFiles
andwatchIgnore
to valid paths and creating a list of matchers to determine if the files should be allowed or ignored through the chokidarignored
match function.This commit reverts changes from 8af0f1a so that the watched file changes are not fixed to the current directory.
Additional note: when a
watchFile
path is removed while chokidar is watching it, recreating thewatchFile
path does not trigger events from chokidar to rerun the tests.PR Checklist
status: accepting prs
Overview