Skip to content

fix: revert "feat: use require to load esm (#5366)" #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: revert "feat: use require to load esm (#5366)" #5381

wants to merge 1 commit into from

Conversation

legendecas
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg changed the title Revert "feat: use require to load esm (#5366)" fix: revert "feat: use require to load esm (#5366)" Jun 18, 2025
@voxpelli
Copy link
Member

Since pinning to previous version works I would say that we skip revert unless we have an estimated double digit percentage regressions (almost impossible to know though) or the estimated fix may be complex / impossible (if we can't get a fix out within a week)

Thoughts?

@legendecas legendecas mentioned this pull request Jun 19, 2025
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legendecas @voxpelli