Feature/overide default window config on open chat buffer #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an 'opts' parameter to CodeCompanion.chat, CodeCompanion.toggle, and the internal Chat.new constructor. This enables users to pass display-related options, such as window dimensions or layout, dynamically to control the appearance and behavior of the chat buffer. The 'opts.window' table can now be used to override the default 'config.display.chat.window' settings for 'open' and 'hide' operations.
refactor(chat-ui): persist window display options The `ChatUI` component now stores window display configuration internally on the UI instance (`self.window`). (only when dynamically added) This allows `ChatUI:hide()` to retrieve the correct layout settings without needing an `opts` parameter. The `ChatUI:open()` method now retrieves the last used window configuration from `self.window` if available. And most importantly: Ensures window layout consistency is maintained when switching between chat buffers.
after we close one
henryoliver
suggested changes
Jun 20, 2025
olimorris
reviewed
Jun 22, 2025
olimorris
reviewed
Jun 22, 2025
|
This looks like a great PR. I'm away right now so will test this out next week some time. |
Apply documentation changes like proposed by Olimorris: Rewords and simplifies the explanation for overriding chat buffer window settings in the documentation, replacing lengthy TIP blocks with a concise sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow passing display options to chat and toggle commands.
We can now pass options to CodeCompanion.chat or CodeCompanion.toggle to override the default window configuration
('config.display.chat.window') such as window dimensions or layout, to dynamically control the appearance and behavior of the chat buffer.
Related Discussion(s)
this was requested in this #1676 discussion
Checklist
CodeCompanion.hasin the init.lua file for my new featuremake allto ensure docs are generated, tests pass and my formatting is applied