Remove the overly broad match from GHSA to limit scanner noise. #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub repo github.com/primefaces/primereact-sass-theme uses a package.json file for this name squatting attack and has a version 10.8.5. The overly broad version range from GitHub that covers every version means that this repo is matched and if someone has it repo checked out it will be potentially considered malicious. Signed-off-by: Caleb Brown <calebbrown@google.com>
elitsa-gosst
approved these changes
Jun 12, 2025
|
This behavior seems to be happening for awhile from Github, and some other IIRC. Do you think this will need a quick campaign to address this in the repo? According to some conversations I have seen, the main reason they did this probably because of an assumption that once a package turned malicious, none of any other versions should be trusted. My quick script shows there seems to be at least hundreds of packages being tagged with version 0. |
|
I think it is fine for now. Most of the time there aren't any issues, but occasionally someone does have problems. I'd prefer that GitHub had more accurate version ranges, but I don't think they have the resources to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub repo github.com/primefaces/primereact-sass-theme uses a package.json file for this name squatting attack and has a version 10.8.5.
The overly broad version range from GitHub that covers every version means that this repo is matched and if someone has the repo checked out it will be potentially considered malicious by a scanning tool.
This change leaves the original version range from @awsactran.