🌱 avoid unnecessary []byte to string conversions
#4539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we just need an io.Reader, so either strings or bytes will do. Signed-off-by: Spencer Schrock <sschrock@google.com>
regexes have a byte equivalent, and we can avoid making a string copy unless we actually need it for the snippet. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
justaugustus and
raghavkaul
and removed request for
a team
spencerschrock
temporarily deployed
to
gitlab
GitHub Actions
Inactive
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4539 +/- ##
==========================================
+ Coverage 66.80% 68.19% +1.39%
==========================================
Files 230 247 +17
Lines 16602 18635 +2033
==========================================
+ Hits 11091 12709 +1618
- Misses 4808 5083 +275
- Partials 703 843 +140 🚀 New features to boost your workflow:
|
|
This pull request has been marked stale because it has been open for 10 days with no activity |
jeffmendoza
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
What is the current behavior?
We cast
[]bytetostring, so we can usestrings.NewReader. We pass this to something that wants anio.Reader, butbytes.NewReaderexists and also satisfiesio.ReaderWhat is the new behavior (if this is a feature change)?**
We avoid unnecessary type conversions, saving some time and making less garbage. I didn't profile the improvement, but it bugs me every time I see it.
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)