-
Notifications
You must be signed in to change notification settings - Fork 561
🌱 cron: repair gitlab project list #4658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Many projects were missing the last character of their URL, which was causing 404 errors and resulting in empty shard files in the cron. The list was repaired using a bash script and an earlier copy of this file: https://raw.githubusercontent.com/ossf/scorecard/8521e516d809edf2b2696e302464d3d5984816a2/cron/internal/data/gitlab-projects.csv Signed-off-by: Spencer Schrock <sschrock@google.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4658 +/- ##
==========================================
+ Coverage 66.80% 68.44% +1.63%
==========================================
Files 230 249 +19
Lines 16602 19032 +2430
==========================================
+ Hits 11091 13026 +1935
- Misses 4808 5133 +325
- Partials 703 873 +170 🚀 New features to boost your workflow:
|
Will wait to merge until we get the token issue resolved |
This pull request has been marked stale because it has been open for 10 days with no activity |
This pull request has been marked stale because it has been open for 10 days with no activity |
What kind of change does this PR introduce?
cron update
What is the current behavior?
Many projects were missing the last character of their URL, which was causing 404 errors and resulting in empty shard files in the cron.
What is the new behavior (if this is a feature change)?**
The list was repaired using a bash script and an earlier copy of this file:
https://raw.githubusercontent.com/ossf/scorecard/8521e516d809edf2b2696e302464d3d5984816a2/cron/internal/data/gitlab-projects.csv
Here's an example diff:
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note
(In particular, describe what changes users might need to make in their
application as a result of this pull request.)