Skip to content

Fix typos #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix typos #876

wants to merge 2 commits into from

Conversation

szepeviktor
Copy link

Found few misspellings.

Please see https://github.com/crate-ci/typos

@gkunz
Copy link
Contributor

gkunz commented Jun 13, 2025

Hi @szepeviktor!

Thank you for the proposed typo fixes. There is, however, a challenge to review and accept such an extensive all-in-one PR - partially due to how the content in this repository is being worked. The content is managed by different SIGs and initiatives. I suggest breaking up the content on a per-directory and per-file level in the docs directory, so that every group can review and integrate the changes.

I would also argue for excluding fixes of meeting minutes and just keep them as "historical documents".

@szepeviktor
Copy link
Author

szepeviktor commented Jun 13, 2025

@gkunz Oh! You want me to be your blond secretary :)
You know what! I revert minutes/* files, rebase the PR and let you and your teams handle the rest.

e.g. git checkout typos -- docs/SCM-BestPractices/

Signed-off-by: Viktor Szépe <viktor@szepe.net>
Signed-off-by: Viktor Szépe <viktor@szepe.net>
@gkunz
Copy link
Contributor

gkunz commented Jun 13, 2025

@szepeviktor having a secretary would be nice, of course! ;-) But seriously, my intention was really to let you know that we appreciate the fixes, but that it is hard for the individual teams to take them on in a single PR. I wanted to avoid the perception that the teams pick individual fixes from this PR and thereby bypassing your contribution. So, the teams may draw from this PR and add you as co-author to potential new PRs.

Thanks again!

@szepeviktor
Copy link
Author

Okay. This only an example!
#922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants