CWE-584

[andrew-costello]

No description provided.

[BartKaras1128]

Mostly just a few random empty spaces here and there that I suggest removing, everything else looks good

[BartKaras1128]

Suggested change

	# SPDX-FileCopyrightText: OpenSSF project contributors
	# SPDX-License-Identifier: MIT
	def do_logic():
	try:
	raise Exception
	finally:
	c = 0
	while c < 5:
	print(f"c is {c}")
	c += 1
	if c == 3:
	break
	# return statement goes here
	# when exception is raised conditionally
	return True
	#####################
	# exploiting above code example
	#####################
	do_logic()
	# SPDX-FileCopyrightText: OpenSSF project contributors
	# SPDX-License-Identifier: MIT
	def do_logic():
	try:
	raise Exception
	finally:
	c = 0
	while c < 5:
	print(f"c is {c}")
	c += 1
	if c == 3:
	break
	# return statement goes here
	# when exception is raised conditionally
	return True
	#####################
	# exploiting above code example
	#####################
	do_logic()

[BartKaras1128]

One more really small change but we should have new lines at the end of our code examples:
Final newline missingPylintC0304:missing-final-newline

[s19110]

I have no other comments apart from @BartKaras1128, but I noticed CWE-584 has not been added to the table in https://github.com/ossf/wg-best-practices-os-developers/blob/main/docs/Secure-Coding-Guide-for-Python/readme.md

Please add a link to your README for this rule to the readme.md for Python's secure coding before merging.

[andrew-costello]

Hello @s19110 , I believe that I have made a good solution for this, Thank you.

[gkunz]

lgtm