Skip to content

refactor(language_server)!: remove support for old configuration objects in initialize and workspace/didChangeConfiguration #11578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Sysix
Copy link
Member

@Sysix Sysix commented Jun 9, 2025

The old configuration was replaced in v0.16.11 #10890.
The server still supported it as a fallback for IntelliJ Plugin, the newest v0.0.10 has now the new configuration object.
Other IDEs or editors would break now. We have workspace/configuration request as a fallback, when the client sent an invalid configuration.

In the README.md of the language server, there are all information how the configuration object should look like.

Copy link
Member Author

Sysix commented Jun 9, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 9, 2025
Copy link

codspeed-hq bot commented Jun 9, 2025

CodSpeed Instrumentation Performance Report

Merging #11578 will not alter performance

Comparing 06-09-refactor_language_server_remove_support_for_old_configuration_objects_in_initialize_and_workspace_didchangeconfiguration_ (338f907) with main (bad91f0)

Summary

✅ 4 untouched benchmarks
⁉️ 34 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ codegen[RadixUIAdoptionSection.jsx] 132.4 µs N/A N/A
⁉️ codegen[binder.ts] 4.8 ms N/A N/A
⁉️ codegen[cal.com.tsx] 38.8 ms N/A N/A
⁉️ codegen[react.development.js] 2.2 ms N/A N/A
⁉️ formatter[RadixUIAdoptionSection.jsx] 298.9 µs N/A N/A
⁉️ formatter[binder.ts] 19.3 ms N/A N/A
⁉️ formatter[cal.com.tsx] 150.4 ms N/A N/A
⁉️ formatter[react.development.js] 9.5 ms N/A N/A
⁉️ lexer[RadixUIAdoptionSection.jsx] 21 µs N/A N/A
⁉️ lexer[binder.ts] 929.4 µs N/A N/A
⁉️ lexer[cal.com.tsx] 5.8 ms N/A N/A
⁉️ lexer[react.development.js] 383.9 µs N/A N/A
⁉️ linter[RadixUIAdoptionSection.jsx] 2.8 ms N/A N/A
⁉️ linter[binder.ts] 149.2 ms N/A N/A
⁉️ linter[cal.com.tsx] 1.3 s N/A N/A
⁉️ linter[react.development.js] 54.7 ms N/A N/A
⁉️ mangler[RadixUIAdoptionSection.jsx] 14.3 µs N/A N/A
⁉️ mangler[binder.ts] 810.3 µs N/A N/A
⁉️ mangler[cal.com.tsx] 3.1 ms N/A N/A
⁉️ mangler[react.development.js] 283.7 µs N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

…cts in `initialize` and `workspace/didChangeConfiguration`
@Sysix Sysix force-pushed the 06-09-refactor_language_server_remove_support_for_old_configuration_objects_in_initialize_and_workspace_didchangeconfiguration_ branch from e90eca6 to 338f907 Compare June 9, 2025 14:03
@Sysix Sysix marked this pull request as ready for review June 9, 2025 14:08
@Sysix Sysix requested a review from camc314 as a code owner June 9, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant