Skip to content

feat(napi/parser): lazy deserializer NodeArray slice method #11680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jun 13, 2025

Implement an optimized slice method for NodeArray in lazy-deserialized AST. It returns a another NodeArray, instead of a plain Array, and doesn't deserialize any of the contents.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Jun 13, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review June 13, 2025 18:24
@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue labels Jun 13, 2025
Copy link
Contributor Author

overlookmotel commented Jun 13, 2025

Merge activity

Implement an optimized `slice` method for `NodeArray` in lazy-deserialized AST. It returns a another `NodeArray`, instead of a plain `Array`, and doesn't deserialize any of the contents.
@graphite-app graphite-app bot force-pushed the 06-13-feat_napi_parser_lazy_deserializer_nodearray_slice_method branch from 819cda9 to dfdebc2 Compare June 13, 2025 18:31
@graphite-app graphite-app bot merged commit dfdebc2 into main Jun 13, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 06-13-feat_napi_parser_lazy_deserializer_nodearray_slice_method branch June 13, 2025 18:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant