Skip to content

feat(sema/check): check for reserved type names #11694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

DonIsaac
Copy link
Contributor

It may make sense to move some or all of this to oxc_parser since switching over token Kind is much faster than string comparisons.

@DonIsaac DonIsaac requested a review from Dunqing as a code owner June 14, 2025 02:03
Copy link
Contributor

graphite-app bot commented Jun 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-semantic Area - Semantic C-enhancement Category - New feature or request labels Jun 14, 2025
Copy link

codspeed-hq bot commented Jun 14, 2025

CodSpeed Instrumentation Performance Report

Merging #11694 will not alter performance

Comparing DonIsaac:don/sema/feat/reserved-type-names (f71dbd0) with main (8c341a2)

Summary

✅ 38 untouched benchmarks

@DonIsaac
Copy link
Contributor Author

DonIsaac commented Jun 14, 2025

yeah it makes sense to do this in the parser imo. Though I wonder why only mangler benchmarks are regressing and not semantic ones too

@Boshen Boshen self-assigned this Jun 16, 2025
@Boshen Boshen force-pushed the don/sema/feat/reserved-type-names branch from 91a696b to f71dbd0 Compare June 18, 2025 04:59
@Boshen Boshen merged commit 4ad86ff into oxc-project:main Jun 18, 2025
24 checks passed
@camc314
Copy link
Contributor

camc314 commented Jun 18, 2025

yeah it makes sense to do this in the parser imo. Though I wonder why only mangler benchmarks are regressing and not semantic ones too

mangler benchmarks are super flaky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants