Skip to content

refactor(parser): move empty ts type parameter checks to parser #11696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DonIsaac
Copy link
Contributor

Part of an effort to move non symbol/scope checks from semantic -> parser.

I intend to only keep checks associated with symbols and scopes in the checker, and move everything back to the parser.
We need to stop the formatter from formatting code when a syntax error occurs. The formatter don't run semantic.

@DonIsaac DonIsaac requested a review from Dunqing as a code owner June 14, 2025 04:38
Copy link
Contributor

graphite-app bot commented Jun 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic labels Jun 14, 2025
@DonIsaac DonIsaac changed the title refactor: move empty ts type parameter checks to parser refactor(parser): move empty ts type parameter checks to parser Jun 14, 2025
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jun 14, 2025
Copy link

codspeed-hq bot commented Jun 14, 2025

CodSpeed Instrumentation Performance Report

Merging #11696 will improve performances by 13.19%

Comparing DonIsaac:don/refactor/check-empty-ts-type-params (5227821) with main (d057652)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 2.7 ms +13.19%

@Boshen Boshen merged commit b0a1561 into oxc-project:main Jun 14, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area - Parser A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants