perf(napi/parser): lazy deser: remove getInternal function in NodeArray
#11698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-performance
Merge activity
|
…Array` (#11698) Move `getElement` function into `NodeArray` class definition, to avoid extra function call to intermediate `getInternal`. This is a hot path, so streamlining it is important for perf.
graphite-app
bot
force-pushed
the
06-14-perf_napi_parser_lazy_deser_avoid_changing_shape_of_nodearray_prototype
branch
from
e65d30d to
a6a82f9
Compare
graphite-app
bot
force-pushed
the
06-14-perf_napi_parser_lazy_deser_remove_getinternal_function_in_nodearray_
branch
from
5fc9565 to
d136acd
Compare
Base automatically changed from
06-14-perf_napi_parser_lazy_deser_avoid_changing_shape_of_nodearray_prototype
to
main
June 14, 2025 11:02
graphite-app
bot
deleted the
06-14-perf_napi_parser_lazy_deser_remove_getinternal_function_in_nodearray_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
getElementfunction intoNodeArrayclass definition, to avoid extra function call to intermediategetInternal. This is a hot path, so streamlining it is important for perf.