Skip to content

fix(napi/parser): lazy deser: remove outdated comments #11699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jun 14, 2025

Remove outdated comments, and clean up comments for NodeArray.

@github-actions github-actions bot added the C-bug Category - Bug label Jun 14, 2025
@overlookmotel overlookmotel marked this pull request as ready for review June 14, 2025 10:55
Copy link
Contributor Author

overlookmotel commented Jun 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor Author

overlookmotel commented Jun 14, 2025

Merge activity

  • Jun 14, 10:55 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 14, 11:01 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Jun 14, 11:07 AM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.
  • Jun 14, 11:18 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jun 14, 11:24 AM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Jun 14, 11:30 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from 06-14-perf_napi_parser_lazy_deser_remove_getinternal_function_in_nodearray_ to graphite-base/11699 June 14, 2025 10:56
@overlookmotel overlookmotel removed the 0-merge Merge with Graphite Merge Queue label Jun 14, 2025
@overlookmotel overlookmotel marked this pull request as draft June 14, 2025 11:02
@graphite-app graphite-app bot changed the base branch from graphite-base/11699 to main June 14, 2025 11:05
@overlookmotel overlookmotel changed the title fix(napi/parser): lazy deser: remove outdated comment fix(napi/parser): lazy deser: remove outdated comments Jun 14, 2025
@overlookmotel overlookmotel force-pushed the 06-14-fix_napi_parser_lazy_deser_remove_outdated_comment branch from 3c4a982 to 7cf3447 Compare June 14, 2025 11:18
@overlookmotel overlookmotel marked this pull request as ready for review June 14, 2025 11:18
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jun 14, 2025
Remove outdated comments, and clean up comments for `NodeArray`.
@graphite-app graphite-app bot force-pushed the 06-14-fix_napi_parser_lazy_deser_remove_outdated_comment branch from 7cf3447 to fcb3084 Compare June 14, 2025 11:24
@graphite-app graphite-app bot merged commit fcb3084 into main Jun 14, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 06-14-fix_napi_parser_lazy_deser_remove_outdated_comment branch June 14, 2025 11:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant