Skip to content

feat(ast): add AstKind for WithClause #11711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2025
Merged

feat(ast): add AstKind for WithClause #11711

merged 1 commit into from
Jun 16, 2025

Conversation

camchenry
Copy link
Member

@camchenry camchenry commented Jun 14, 2025 •
edited
Loading

I got tired of just working on other parser stuff, so thought I'd lend a hand here as I'm able

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-enhancement Category - New feature or request labels Jun 14, 2025
@camchenry Graphite App
Copy link
Member Author

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camchenry camchenry force-pushed the 06-14-feat_ast_add_astkind_for_withclause_ branch from 3b9b891 to f5e8d98 Compare June 14, 2025 19:55
@camchenry camchenry marked this pull request as ready for review June 14, 2025 19:58
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 14, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11711 will not alter performance

Comparing 06-14-feat_ast_add_astkind_for_withclause_ (37d4c9a) with main (989634a)

Summary

✅ 38 untouched benchmarks

@therewillbecode therewillbecode mentioned this pull request Jun 15, 2025
Closed
@camc314 camc314 force-pushed the 06-14-feat_ast_add_astkind_for_withclause_ branch from f5e8d98 to b2a2922 Compare June 16, 2025 09:14
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 16, 2025
@camc314 Graphite App
Copy link
Contributor

camc314 commented Jun 16, 2025 •
edited by graphite-app bot
Loading

Merge activity

@camchenry
feat(ast): add AstKind for WithClause (#11711)
37d4c9a 
- part of #11490

I got tired of just working on other parser stuff, so thought I'd lend a hand here as I'm able
@graphite-app graphite-app bot force-pushed the 06-14-feat_ast_add_astkind_for_withclause_ branch from b2a2922 to 37d4c9a Compare June 16, 2025 09:22
@graphite-app graphite-app bot merged commit 37d4c9a into main Jun 16, 2025
24 of 25 checks passed
@graphite-app graphite-app bot deleted the 06-14-feat_ast_add_astkind_for_withclause_ branch June 16, 2025 09:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 16, 2025
@oxc-bot oxc-bot mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camchenry @camc314