Skip to content

feat(ast): Add AstKind to TSIndexSignature node #11724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025

Conversation

therewillbecode
Copy link
Contributor

This PR is part of the ongoing work in #11490.

Adds AstKind to TSIndexSignature nodes by removing the entry from the list of exceptions in ast_tools.

@therewillbecode therewillbecode changed the title refactor(ast): Add AstKind to TSIndexSignature node refactor(ast): Add AstKind to TSIndexSignature node Jun 15, 2025
Copy link
Contributor

graphite-app bot commented Jun 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 15, 2025
Copy link

codspeed-hq bot commented Jun 15, 2025

CodSpeed Instrumentation Performance Report

Merging #11724 will degrade performances by 13.18%

Comparing therewillbecode:add-ast-kind-ts-index-sig (d0989a1) with main (37d4c9a)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3.1 ms 3.5 ms -13.18%

@therewillbecode therewillbecode changed the title refactor(ast): Add AstKind to TSIndexSignature node feat(ast): Add AstKind to TSIndexSignature node Jun 15, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Jun 15, 2025
@camc314 camc314 force-pushed the add-ast-kind-ts-index-sig branch from 3c2834c to d0989a1 Compare June 16, 2025 09:31
@camc314 camc314 merged commit 866470a into oxc-project:main Jun 16, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants