Skip to content

feat(ast): Add AstKind to TSCallSignatureDeclaration node #11725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

feat(ast): Add AstKind to TSCallSignatureDeclaration node #11725

merged 2 commits into from
Jun 16, 2025

Conversation

therewillbecode
Copy link
Contributor

This PR is part of the ongoing work in #11490 .

Adds AstKind to TSCallSignatureDeclaration nodes by removing the entry from the list of exceptions in ast_tools.

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jun 15, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 15, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 15, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11725 will improve performances by 15.68%

Comparing therewillbecode:astkind-add-tscallsig (5c03ebc) with main (866470a)

Summary

⚡ 1 improvements
✅ 37 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ mangler[cal.com.tsx] 3.5 ms 3.1 ms +15.68%

@therewillbecode therewillbecode marked this pull request as draft June 15, 2025 13:11
@therewillbecode therewillbecode changed the title refactor(ast): Add AstKind to TSCallSignatureDeclaration node feat(ast): Add AstKind to TSCallSignatureDeclaration node Jun 15, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Jun 15, 2025
@therewillbecode therewillbecode marked this pull request as ready for review June 15, 2025 13:54
@therewillbecode therewillbecode mentioned this pull request Jun 15, 2025
Open
@camc314 camc314 force-pushed the astkind-add-tscallsig branch from 1cf079c to 5c03ebc Compare June 16, 2025 09:54
@camc314 camc314 merged commit c25b153 into oxc-project:main Jun 16, 2025
24 of 25 checks passed
@oxc-bot oxc-bot mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
A-ast Area - AST A-ast-tools Area - AST tools A-formatter Area - Formatter A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@therewillbecode @camc314