Skip to content

refactor(semantic): rename function params #11775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jun 17, 2025

Pure refactor. These methods all took symbols: &Scoping. Rename symbols to scoping to better reflect what the function param is.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jun 17, 2025
@overlookmotel overlookmotel marked this pull request as ready for review June 17, 2025 13:25
@overlookmotel overlookmotel requested a review from Dunqing as a code owner June 17, 2025 13:25
@overlookmotel
Copy link
Member Author

Just renames things, no substantive changes, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jun 17, 2025
Copy link
Member Author

overlookmotel commented Jun 17, 2025

Merge activity

@overlookmotel overlookmotel removed the request for review from Dunqing June 17, 2025 13:26
Copy link

codspeed-hq bot commented Jun 17, 2025

CodSpeed Instrumentation Performance Report

Merging #11775 will not alter performance

Comparing 06-17-refactor_semantic_rename_function_params (eccac91) with main (14f7033)

Summary

✅ 38 untouched benchmarks

Pure refactor. These methods all took `symbols: &Scoping`. Rename `symbols` to `scoping` to better reflect what the function param is.
@graphite-app graphite-app bot force-pushed the 06-17-refactor_semantic_rename_function_params branch from cd9e92f to eccac91 Compare June 17, 2025 13:33
@graphite-app graphite-app bot merged commit eccac91 into main Jun 17, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 06-17-refactor_semantic_rename_function_params branch June 17, 2025 13:40
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant