Skip to content

perf(napi/parser): faster deserialization of Vecs in raw transfer #11776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jun 17, 2025

Small perf optimization to raw transfer. Don't use 2 different counters in the loop when deserializing Vecs. Do what Rust's slice iterators do, and use current and end pointers.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-performance Category - Solution not expected to change functional behavior, only performance labels Jun 17, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 06-17-perf_napi_parser_faster_deserialization_of_vec_s_in_raw_transfer branch from ad9d000 to 2f3a43c Compare June 17, 2025 13:31
@overlookmotel overlookmotel marked this pull request as ready for review June 17, 2025 13:33
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jun 17, 2025
Copy link
Contributor Author

overlookmotel commented Jun 17, 2025

Merge activity

…11776)

Small perf optimization to raw transfer. Don't use 2 different counters in the loop when deserializing `Vec`s. Do what Rust's slice iterators do, and use current and end pointers.
@graphite-app graphite-app bot force-pushed the 06-17-perf_napi_parser_faster_deserialization_of_vec_s_in_raw_transfer branch from 2f3a43c to 21c8852 Compare June 17, 2025 13:56
@graphite-app graphite-app bot merged commit 21c8852 into main Jun 17, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 06-17-perf_napi_parser_faster_deserialization_of_vec_s_in_raw_transfer branch June 17, 2025 14:03
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast-tools Area - AST tools C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant