Skip to content

feat(linter): use oxlint via napi #11779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jun 17, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review June 17, 2025 13:58
@github-actions github-actions bot added A-cli Area - CLI C-enhancement Category - New feature or request labels Jun 17, 2025
Copy link
Contributor Author

camc314 commented Jun 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as draft June 17, 2025 13:58
Copy link

codspeed-hq bot commented Jun 17, 2025

CodSpeed Instrumentation Performance Report

Merging #11779 will improve performances by 15.14%

Comparing c/06-17-feat_linter_use_oxlint_via_napi (9f3254f) with main (9a2548a)

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ linter[RadixUIAdoptionSection.jsx] 2.6 ms N/A N/A
⁉️ linter[binder.ts] 149.9 ms N/A N/A
⁉️ linter[cal.com.tsx] 1.2 s N/A N/A
⁉️ linter[react.development.js] 54.9 ms N/A N/A
mangler[cal.com.tsx] 3.5 ms 3.1 ms +15.14%

@camc314 camc314 force-pushed the c/06-17-feat_linter_use_oxlint_via_napi branch 8 times, most recently from 1f11ed5 to bdba075 Compare June 17, 2025 15:39
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should have two builds, a bin and a lib build 🤔

@camc314
Copy link
Contributor Author

camc314 commented Jun 18, 2025

Maybe we should have two builds, a bin and a lib build 🤔

on the npm side? or the rust side?

that's what i've got on the rust side.

the end goal, i think was going to be:

#[napi]
fn linter(/* some args all optional*/) {}


fn main() {
    linter(NOne, None...)
}

that way you can still use cargo build --bin oxlint while also be able to invoke from the node side

@camc314 camc314 force-pushed the c/06-17-feat_linter_use_oxlint_via_napi branch 4 times, most recently from 2961d01 to f3d369c Compare June 20, 2025 09:54
@camc314 camc314 force-pushed the c/06-17-feat_linter_use_oxlint_via_napi branch from 5034662 to 8931d94 Compare June 23, 2025 09:39
@github-actions github-actions bot added A-linter Area - Linter A-editor Area - Editor and Language Server labels Jun 24, 2025
@camc314 camc314 closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants