Skip to content

feat(minifier): remove dead code that evaluates to a constant value #11788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

feat(minifier): remove dead code that evaluates to a constant value #11788

merged 1 commit into from
Jun 18, 2025
+69 −9

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jun 18, 2025 •
edited
Loading

part of #10843

Approach: build a constant table after constant evaluation on variable declarations, use these constant values during dead code removal.

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jun 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jun 18, 2025
@Boshen Boshen force-pushed the 06-18-feat_minifier_remove_dead_code_that_evaluates_to_constant_value branch from 07258ec to 7aaa052 Compare June 18, 2025 09:05
@Boshen Boshen changed the title feat(minifier): remove dead code that evaluates to constant value feat(minifier): remove dead code that evaluates to a constant value Jun 18, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 18, 2025 •
edited
Loading

CodSpeed Instrumentation Performance Report

Merging #11788 will not alter performance

Comparing 06-18-feat_minifier_remove_dead_code_that_evaluates_to_constant_value (d462ead) with main (3d88eeb)

Summary

✅ 38 untouched benchmarks

@Boshen Boshen force-pushed the 06-18-feat_minifier_remove_dead_code_that_evaluates_to_constant_value branch 3 times, most recently from 9ecc48d to b44cc33 Compare June 18, 2025 11:15
@Boshen Boshen marked this pull request as ready for review June 18, 2025 11:15
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jun 18, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Jun 18, 2025 •
edited by graphite-app bot
Loading

Merge activity

@Boshen
feat(minifier): remove dead code that evaluates to a constant value (#…
d462ead 
…11788)

part of #10843

Approach: build a constant table after constant evaluation on variable declarations, use these constant values during dead code removal.
@graphite-app graphite-app bot force-pushed the 06-18-feat_minifier_remove_dead_code_that_evaluates_to_constant_value branch from b44cc33 to d462ead Compare June 18, 2025 11:22
@graphite-app graphite-app bot merged commit d462ead into main Jun 18, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 06-18-feat_minifier_remove_dead_code_that_evaluates_to_constant_value branch June 18, 2025 11:28
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen