Skip to content

feat(minifier): remove unused variable declaration #11796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jun 18, 2025

closes #10033

Copy link
Contributor

graphite-app bot commented Jun 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Jun 18, 2025
Copy link

codspeed-hq bot commented Jun 18, 2025

CodSpeed Instrumentation Performance Report

Merging #11796 will degrade performances by 37.9%

Comparing 06-18-feat_minifier_remove_unused_variable_declaration (ea67ff4) with main (b172cef)

Summary

❌ 4 regressions
✅ 30 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[RadixUIAdoptionSection.jsx] 66.1 µs 82.2 µs -19.64%
minifier[binder.ts] 3.5 ms 4.8 ms -27.62%
minifier[cal.com.tsx] 23.8 ms 38.4 ms -37.9%
minifier[react.development.js] 1.8 ms 2.8 ms -34.56%

@Boshen Boshen force-pushed the 06-18-feat_minifier_remove_unused_variable_declaration branch from 8007ceb to c6f5d22 Compare June 19, 2025 06:15
@github-actions github-actions bot added the A-semantic Area - Semantic label Jun 19, 2025
@Boshen Boshen force-pushed the 06-18-feat_minifier_remove_unused_variable_declaration branch 7 times, most recently from b8c652b to b18cc1c Compare July 15, 2025 13:56
@Boshen Boshen force-pushed the 06-18-feat_minifier_remove_unused_variable_declaration branch from b18cc1c to ea67ff4 Compare July 16, 2025 05:22
@Boshen Boshen marked this pull request as ready for review July 16, 2025 05:23
@Boshen Boshen requested a review from Dunqing as a code owner July 16, 2025 05:23
@Boshen
Copy link
Member Author

Boshen commented Jul 16, 2025

I'll resolve the performance regression when I finalize the algorithm.

@Boshen Boshen merged commit fb8289c into main Jul 16, 2025
25 checks passed
@Boshen Boshen deleted the 06-18-feat_minifier_remove_unused_variable_declaration branch July 16, 2025 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minifier: remove unused variable declaration
1 participant