-
-
Notifications
You must be signed in to change notification settings - Fork 631
feat(linter): add read_to_arena_str
function
#11823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): add read_to_arena_str
function
#11823
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11823 will improve performances by 15.08%Comparing Summary
Benchmarks breakdown
|
@camc314 I think this should work, but we'll need to check it doesn't regress performance before making a release that uses it. There are issues in Rust repo about optimizations that make |
16b9bfd
to
3487e9a
Compare
c1576bc
to
9261bd0
Compare
3487e9a
to
f2ce5ad
Compare
9261bd0
to
17cb9ca
Compare
17cb9ca
to
4adbe4b
Compare
perf appears to be identical (or within noise limits) ( i benched this on my PR that's on top of this one so we're actually using this fn!) |
Merge activity
|
Alternative to #11816. Read a file from disk directly into an `Allocator`. Unfortunately, involves a pretty egregious hack (see comments in code), but this appears to be the only way that stable Rust provides to read a file into uninitialized memory without UB. Bonkers!
4adbe4b
to
dc6f584
Compare
Alternative to #11816. Read a file from disk directly into an
Allocator
.Unfortunately, involves a pretty egregious hack (see comments in code), but this appears to be the only way that stable Rust provides to read a file into uninitialized memory without UB. Bonkers!