Skip to content

feat(linter): read source text into the arena #11825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Jun 19, 2025

No description provided.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Jun 19, 2025
@camc314 camc314 marked this pull request as ready for review June 19, 2025 21:50
Copy link
Contributor Author

camc314 commented Jun 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Jun 19, 2025

CodSpeed Instrumentation Performance Report

Merging #11825 will create unknown performance changes

Comparing c/06-19-feat_linter_read_source_text_into_the_arena (816ff03) with main (b39d1fa)

Summary

🆕 38 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[RadixUIAdoptionSection.jsx] N/A 132.5 µs N/A
🆕 codegen[binder.ts] N/A 4.8 ms N/A
🆕 codegen[cal.com.tsx] N/A 38.8 ms N/A
🆕 codegen[react.development.js] N/A 2.2 ms N/A
🆕 formatter[RadixUIAdoptionSection.jsx] N/A 329.7 µs N/A
🆕 formatter[binder.ts] N/A 20.6 ms N/A
🆕 formatter[cal.com.tsx] N/A 161 ms N/A
🆕 formatter[react.development.js] N/A 10.1 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.9 µs N/A
🆕 lexer[binder.ts] N/A 929.8 µs N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[react.development.js] N/A 384.1 µs N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.6 ms N/A
🆕 linter[binder.ts] N/A 149.9 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[react.development.js] N/A 54.9 ms N/A
🆕 mangler[RadixUIAdoptionSection.jsx] N/A 14.5 µs N/A
🆕 mangler[binder.ts] N/A 809.5 µs N/A
🆕 mangler[cal.com.tsx] N/A 3.1 ms N/A
🆕 mangler[react.development.js] N/A 283.8 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@camc314 camc314 force-pushed the c/06-19-feat_linter_read_source_text_into_the_arena branch from 09b9410 to d3a2be9 Compare June 19, 2025 22:01
@camc314 camc314 requested a review from Sysix as a code owner June 19, 2025 22:01
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Jun 19, 2025
@camc314 camc314 force-pushed the c/06-19-feat_linter_read_source_text_into_the_arena branch from d3a2be9 to 8b4aca4 Compare June 19, 2025 22:07
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the linter well enough to be able to effectively review. But if you're happy with it, and it doesn't hurt perf, merge it!

@overlookmotel overlookmotel changed the base branch from 06-19-feat_linter_add_read_to_arena_str_function to graphite-base/11825 June 20, 2025 00:50
@graphite-app graphite-app bot force-pushed the graphite-base/11825 branch from 57059d1 to 4adbe4b Compare June 20, 2025 00:58
@graphite-app graphite-app bot force-pushed the c/06-19-feat_linter_read_source_text_into_the_arena branch from 8b4aca4 to 78db07c Compare June 20, 2025 00:58
@graphite-app graphite-app bot changed the base branch from graphite-base/11825 to 06-19-feat_linter_add_read_to_arena_str_function June 20, 2025 00:58
@graphite-app graphite-app bot force-pushed the c/06-19-feat_linter_read_source_text_into_the_arena branch from 78db07c to 1f316e4 Compare June 20, 2025 00:58
@graphite-app graphite-app bot changed the base branch from 06-19-feat_linter_add_read_to_arena_str_function to graphite-base/11825 June 20, 2025 09:04
@graphite-app graphite-app bot force-pushed the graphite-base/11825 branch from 4adbe4b to dc6f584 Compare June 20, 2025 09:07
@graphite-app graphite-app bot force-pushed the c/06-19-feat_linter_read_source_text_into_the_arena branch from 1f316e4 to 6cf8958 Compare June 20, 2025 09:07
@graphite-app graphite-app bot changed the base branch from graphite-base/11825 to main June 20, 2025 09:08
@graphite-app graphite-app bot force-pushed the c/06-19-feat_linter_read_source_text_into_the_arena branch from 6cf8958 to 4d15a10 Compare June 20, 2025 09:08
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Jun 20, 2025
Copy link
Contributor Author

camc314 commented Jun 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the c/06-19-feat_linter_read_source_text_into_the_arena branch from 4d15a10 to 816ff03 Compare June 20, 2025 09:25
@graphite-app graphite-app bot merged commit 816ff03 into main Jun 20, 2025
26 checks passed
@graphite-app graphite-app bot deleted the c/06-19-feat_linter_read_source_text_into_the_arena branch June 20, 2025 09:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-editor Area - Editor and Language Server A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants