Add test for PDF010 #15
Conversation
Codecov Report
@@ Coverage Diff @@
## main #15 +/- ##
==========================================
+ Coverage 84.70% 85.29% +0.58%
==========================================
Files 26 26
Lines 340 340
==========================================
+ Hits 288 290 +2
+ Misses 52 50 -2
Continue to review full report at Codecov.
|
tests/conftest_test.py
Outdated
| ( | ||
| pytest.param( | ||
| "conftest = 'foo'", | ||
| id="set conftest", |
tests/conftest_test.py
Outdated
| pytest.param( | ||
| "import conftest", | ||
| "1:0: PDF010 import from 'conftest' found", | ||
| id="import from conftest", | ||
| ), |
There was a problem hiding this comment.
nice! Can you also add a testcase which has from conftest import foo? (this one may not pass... 😳 )
There was a problem hiding this comment.
this one likely passes, but from pandas.conftest import foo likely won't - can you include that one as well? If you know how to fix the source code to make it pass, then even better 👍
There was a problem hiding this comment.
from pandas.conftest import foo didn't pass -- should i open an issue for that case separately?
There was a problem hiding this comment.
sure - let's take this one as it is, and if you're interested in making a separate PR to make from pandas.conftest import foo pass as well, then even better! (else I'll do it later)
There was a problem hiding this comment.
yeh that's what i was getting at 🤣 i wanted to work on making tests pass for that case
There was a problem hiding this comment.
😆 cool - I went and opened a new issue anyway, #16
Closes #12