Skip to content

Add gap between ActionList label and trailingVisual #6177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jun 30, 2025

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jun 6, 2025

Adds proper gap between label and trailing visual. Also removes the inactive text if its not needed.

Closes #6154

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Sorry, something went wrong.

jonrohan and others added 17 commits May 20, 2025 21:22

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

changeset-bot bot commented Jun 6, 2025

🦋 Changeset detected

Latest commit: 746fb33

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 6, 2025
Copy link
Contributor

github-actions bot commented Jun 6, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Jun 6, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 92.48 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js 92.7 KB (+0.16% 🔺)

@github-actions github-actions bot requested a deployment to storybook-preview-6177 June 6, 2025 23:40 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6177 June 6, 2025 23:54 Inactive
Base automatically changed from css_modules_remove_flag/actionlist to main June 11, 2025 19:00

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@langermank langermank marked this pull request as ready for review June 30, 2025 16:23
@Copilot Copilot AI review requested due to automatic review settings June 30, 2025 16:23
@langermank langermank requested a review from a team as a code owner June 30, 2025 16:23
@langermank langermank requested a review from hectahertz June 30, 2025 16:23
@joshblack
Copy link
Member

Would it be easy to add a screenshot/e2e test to capture this behavior or not really? 👀

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@langermank
Copy link
Contributor Author

@joshblack great call, I'm doing a few other bugs for AL this week and I'll add this into a followup PR!

@langermank langermank added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 5e1ed83 Jun 30, 2025
36 checks passed
@langermank langermank deleted the add-col-gap-actionlist branch June 30, 2025 18:44
@primer primer bot mentioned this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActionList.TrailingVisual has insufficient left padding
5 participants