Skip to content

MAINT: update maximum numpy version to build against #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

rgommers
Copy link
Collaborator

@rgommers rgommers commented Apr 1, 2025

The rule is <N+3, and numpy 2.2.x is out, so the bound should be <2.5.

Also add a pytest.ini file that will turn deprecation warnings in the test suite into errors. This will catch any deprecations from numpy or python, so that they can be fixed in time. Having the test suite run deprecation-warning-free is the guarantee that the <N+3 upper bound will work. The pytest.ini contents are derived from what NumPy and SciPy also use.

@rdbisme
Copy link
Collaborator

rdbisme commented Apr 2, 2025

Can we maybe just use pyproject.toml. No big opinions here, just maybe having the same syntax?

@rgommers
Copy link
Collaborator Author

rgommers commented Apr 3, 2025

Ah for pytest config (https://doc.pytest.org/en/latest/reference/customize.html#pyproject-toml). Yes, we can - that does seem nicer indeed. That support is relatively new, so I didn't think of it. Will update.

We should also be using pyproject.toml's [project] section for project metadata instead of hiding it in setup.py, but I'll leave that for another time.

The rule is <N+3, and numpy 2.2.x is out, so the bound should
be <2.5.

Also add a `pytest.ini` file that will turn deprecation warnings
in the test suite into errors. This will catch any deprecations
from `numpy` or `python`, so that they can be fixed in time.
Having the test suite run deprecation-warning-free is the guarantee
that the <N+3 upper bound will work.
@rgommers rgommers force-pushed the update-max-np-version branch from 63aea5a to cccfa4f Compare April 3, 2025 08:01
@rdbisme rdbisme merged commit 26974d4 into pydata:master Apr 6, 2025
39 checks passed
@rgommers rgommers deleted the update-max-np-version branch April 6, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants