CI: add macOS arm64, Linux aarch, remove i686 wheels, trim test matrix #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is unnecessary to run tests on every Python version - if minimum and maximum supported versions pass, things should be good. Otherwise, there is too much duplication given all the extra platforms (arm64/aarch64) that we're running on now.
NumPy hasn't shipped i686 wheels in a while. This causes the i686 wheels in this repo to build NumPy from source, and hence the `ubuntu-latest` wheel build job takes a very long time. It doesn't make too much sense to ship wheels for a platform that NumPy doesn't support, so disable `manylinux_i686` and `musllinux_i686`.
rdbisme
reviewed
May 9, 2025
Also refactor Python version coverage a bit, so all supported Python feature versions are tested again, without having too much duplication The dense matrix of platforms x architectures x python versions would otherwise be too large.
|
Comments addressed now - please take another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modernizes the CI setup to do the following:
ubuntu-22.04andubuntu-latest(both x86-64, not useful)exclude) jobsmacos-latestswitching from x86-64 to arm64, see e.g. https://pypi.org/project/Bottleneck/1.4.2/#files)I left the
windows-2019/windows-latesttest jobs duplication; that's probably also not useful, but it's harder to be sure of that than on Linux. Windows arm64 can be added later, once NumPy 2.3.0 publisheswin-arm64wheels.Adds the platforms as proposed in gh-474
Closes gh-464
Closes gh-395
Closes gh-394