Drop row with duplicated index #929
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are cases in yahoo data where there are duplicated rows, this fix will remove the second duplicated row if it exists. A stack overflow thread that contains people facing this error is https://stackoverflow.com/questions/57885790/valueerror-index-contains-duplicate-entries-cannot-reshape-pandas-datareader
Extra line was causing Check style and formatting to fail, hence removed it
|
What if the values differ but he index doesn't? Should PDR return what Yahoo does? |
|
I think you should only drop if the row is identical and the index is identical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases in yahoo data where there are duplicated rows, this simple fix will remove the second duplicated row if it exists. A stack overflow thread that contains people facing this error is https://stackoverflow.com/questions/57885790/valueerror-index-contains-duplicate-entries-cannot-reshape-pandas-datareader
git diff upstream/master -u -- "*.py" | flake8 --diffblack --check pandas_datareader