Updates to fix linting task in ci/cd pipeline #947
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update black Fix nested exceptions
- Add isort to dev dependencies - Add dev dependencies to setup.py - Add lint session to tox for local testing
gw-moore
changed the title
Codecov Report
@@ Coverage Diff @@
## main #947 +/- ##
===========================================
- Coverage 73.19% 61.60% -11.59%
===========================================
Files 65 62 -3
Lines 2932 2870 -62
Branches 315 411 +96
===========================================
- Hits 2146 1768 -378
- Misses 704 1035 +331
+ Partials 82 67 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I merged @bashtage's |
|
These have been fixed in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI/CD pipeline is failing because the
requirements-dev.txtfile is missingisort. I ran black and isort after making the update and his modified some additional files. The pipeline is still failing due to flake8.Changes
Adds isort to dev dependencies
Adds dev dependencies to setup.py
Adds lint session to tox for local testing
closes #xxxx
tests added / passed
passes
git diff upstream/master -u -- "*.py" | flake8 --diffpasses
black --check pandas_datareaderadded entry to docs/source/whatsnew/vLATEST.txt