Skip to content

Images on the page about light and dark themes broken #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabalafou opened this issue May 12, 2025 · 2 comments
Open

Images on the page about light and dark themes broken #2208

gabalafou opened this issue May 12, 2025 · 2 comments
Labels
good first issue Good for newcomers kind: bug Something isn't working kind: documentation Improvements or additions to documentation

Comments

@gabalafou
Copy link
Collaborator

gabalafou commented May 12, 2025

The images are broken on the docs page, Light and dark themes.

This seems related to #2190, which replaced URLs to Unsplash images with Picsum. So maybe we should do the same with that page. Or maybe upload actual images to the repo to avoid this issue recurring in the future?

Once this is fixed the "unsplash.com" entry in the linkcheck_ignore list in conf.py should be removed.

@gabalafou gabalafou added kind: documentation Improvements or additions to documentation good first issue Good for newcomers kind: bug Something isn't working labels May 12, 2025
@trallard
Copy link
Collaborator

I think we can update these images in the light and dark themes docs page manually?

Which makes me think: when/how often should we be running the script to update our kitchen sink pages? @drammock

@drammock
Copy link
Collaborator

when/how often should we be running the script to update our kitchen sink pages?

historically it's been ad-hoc. I guess it makes sense to make that part of the RC release process? It's possible that some cycles it might be vacuous, if the kitchen sink hasn't changed (in my limited experience it seems to change slowly / in spurts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind: bug Something isn't working kind: documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants