Skip to content

feat(remix-routes-option-adapter): export DefineRouteFunction type #13614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bmsuseluda
Copy link

Hello together,

in the remix days i used the type DefineRouteFunction to structure and reuse my route functions. Now with React Router 7 and the remix-routes-option-adapter this type is not exported anymore.

This merge request exports it again.

Thanks for your great work
bmsuseluda

Copy link

changeset-bot bot commented May 15, 2025

🦋 Changeset detected

Latest commit: c546711

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/remix-routes-option-adapter Major
create-react-router Major
react-router Major
react-router-dom Major
@react-router/architect Major
@react-router/cloudflare Major
@react-router/dev Major
@react-router/fs-routes Major
@react-router/express Major
@react-router/node Major
@react-router/serve Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 15, 2025

Hi @bmsuseluda,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 15, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11
Copy link
Contributor

Can you rebase this onto dev since it changes source code?

@bmsuseluda
Copy link
Author

Can you rebase this onto dev since it changes source code?

Would a merge be fine too? A rebase from my branch, which is base on main, to dev on a repository i do not know is really difficult.

@MichaelDeBoey MichaelDeBoey changed the title chore: export DefineRouteFunction type from remix adapter feat(remix-routes-option-adapter): export DefineRouteFunction type Jul 4, 2025
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@brophdawg11 brophdawg11 changed the base branch from main to brophdawg11/gh13614 July 7, 2025 14:49
@brophdawg11 brophdawg11 merged commit 682e277 into remix-run:brophdawg11/gh13614 Jul 7, 2025
1 check passed
@brophdawg11
Copy link
Contributor

Merged to a temp branch of mine and will merge to dev in #13945

brophdawg11 added a commit that referenced this pull request Jul 7, 2025
…13614) (#13945)

Co-authored-by: bmsuseluda <gunslinger@sensonar.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants