-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
feat(remix-routes-option-adapter): export DefineRouteFunction
type
#13614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-routes-option-adapter): export DefineRouteFunction
type
#13614
Conversation
🦋 Changeset detectedLatest commit: c546711 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @bmsuseluda, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Can you rebase this onto |
Would a merge be fine too? A rebase from my branch, which is base on main, to dev on a repository i do not know is really difficult. |
DefineRouteFunction
type from remix adapterDefineRouteFunction
type
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Merged to a temp branch of mine and will merge to |
Hello together,
in the remix days i used the type
DefineRouteFunction
to structure and reuse my route functions. Now with React Router 7 and theremix-routes-option-adapter
this type is not exported anymore.This merge request exports it again.
Thanks for your great work
bmsuseluda