You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If some fields cannot be verified because they are not present in the cert, I'm tempted to say we should remove them from the provenance that --print-provenance prints. This requires some more discussions.
pros: only trust what can be verified
cons: someone how verifies their own package know that they have not altered with the content and may want to trust it anyway. Arguably they should be using a different builder if they want this level of guarantees
If some fields cannot be verified because they are not present in the cert, I'm tempted to say we should remove them from the provenance that --print-provenance prints.
I agree but, even better, we should ask npm to remove them from the provenance they generate. We can create an issue on their repo to have them removed if we find any. We discussed this earlier and agreed in principle with the GitHub folks on this.
Activity
laurentsimon commentedon Feb 21, 2023
If some fields cannot be verified because they are not present in the cert, I'm tempted to say we should remove them from the provenance that
--print-provenance
prints. This requires some more discussions.pros: only trust what can be verified
cons: someone how verifies their own package know that they have not altered with the content and may want to trust it anyway. Arguably they should be using a different builder if they want this level of guarantees
/cc @ianlewis @asraa
ianlewis commentedon Feb 22, 2023
I agree but, even better, we should ask npm to remove them from the provenance they generate. We can create an issue on their repo to have them removed if we find any. We discussed this earlier and agreed in principle with the GitHub folks on this.
laurentsimon commentedon Feb 22, 2023
Good idea. Please link the issue once you have created one on their repo
ianlewis commentedon Feb 28, 2023
I linked to here from the issue in their repo. Anyone who has access should see it above.
laurentsimon commentedon Mar 15, 2023
Example of claims and change in parsing sigstore/fulcio#754 (comment)
laurentsimon commentedon May 18, 2023
Done in #572. Closing
Add tags for renovate-bot (slsa-framework#493)
ramonpetgrave64 commentedon Jun 10, 2024
reopening, since
(n *Npm) verifiedProvenanceBytes()
is not yet implemented.slsa-verifier/verifiers/internal/gha/npm.go
Lines 224 to 229 in 18c5f13
5 remaining items