Migrate Dockerfile to Node.js Base Image for Proper Application Deployment #4662
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All Jest tests passed! This PR is ready to merge. |
|
please review this pr |
|
@MostlyKIGuess Please review. |
|
I tried building both of them. |
| # Second stage: Final stage | ||
| FROM python:3.9-slim | ||
| # Run linting and tests | ||
| RUN npm run lint |
There was a problem hiding this comment.
we technically don't need this.
|
If we can have the same size, it would be nice to have. |
|
✅ Improvements: Proper .dockerignore assumed (e.g., excludes node_modules, .git, etc.). More explicit Node.js version for reproducibility. Added HEALTHCHECK for container monitoring.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the
Dockerfileto use a Node.js-based image with a multi-stage build setup for Music Blocks.The goal is to create an optimized production container by separating the build and runtime environments.
Changes Made
First Stage (Build Stage):
node:18-slim/app.npm install).npm run lint) and testing (npm run test).Second Stage (Production Stage):
node:18-slim(clean and minimal).appuser) for better security.npm install --production).npm run serve.Related Issue
Closes #4661