Skip to content

Should we restore the feature changing dots/images color? #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiy4h opened this issue Jan 13, 2020 · 1 comment
Open

Should we restore the feature changing dots/images color? #17

kiy4h opened this issue Jan 13, 2020 · 1 comment

Comments

@kiy4h
Copy link

kiy4h commented Jan 13, 2020

I was planning to add the collaboration feature to the activity, but I'm not sure what the function dot_click was in the story activity. Should I just remove all of it, or re-implement it?

https://github.com/sugarlabs/story/blob/master/StoryActivity.py#L707
https://github.com/sugarlabs/story/blob/master/StoryActivity.py#L711

EDIT: I've noticed that the story activity had a feature where the player clicks on the "dots" (the images) to change its color.
Should we restore this feature, or let it fade away?

@kiy4h kiy4h changed the title Should we remove dot_click functions? Should we restore the feature changing dots/images color? Jan 13, 2020
@quozl
Copy link
Contributor

quozl commented Jan 21, 2020

https://github.com/search?q=org%3Asugarlabs+send_dot_click&type=Code

Looks from this that send_dot_click is a copy and paste error; code common to several activities but not called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants