Skip to content

LinearGradient prop - not a valid number or percentage string #9

Open
@moritzkarliczek

Description

@moritzkarliczek

The value of the offset property needs to be parsed to a number or a valid percentage string. In this example offset=".05" needs to be parsed to offset={0.05}.

At the moment i get a warning:

WARN ".05" is not a valid number or percentage string.

Example SVG:

  ...
    <linearGradient id="myGradient" gradientTransform="rotate(90)">
      <stop offset=".05" stop-color="gold" />
      <stop offset=".95" stop-color="red" />
    </linearGradient>
...

it beeing converted to:

...
<LinearGradient id="test_svg__a" gradientTransform="rotate(90)">
          <Stop offset=".05" stopColor="gold" />
          <Stop offset=".95" stopColor="red" />
</LinearGradient>
...

what would be correct: (which is what SVGR is doing)

...
<LinearGradient id="test_svg__a" gradientTransform="rotate(90)">
          <Stop offset={0.05} stopColor="gold" />
          <Stop offset={0.95} stopColor="red" />
</LinearGradient>
...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions