This repository was archived by the owner on May 24, 2025. It is now read-only.
Editorial: add note about casting to f16 #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! The proposed text addresses my concern. The Firefox implementation is incredibly helpful. Still, I think the specification should explain the issues independent of a particular implementation. I defer to the editor team on whether it is appropriate to include a link to the Firefox code. |
|
Going to go ahead and land this now; we can always bikeshed the wording in stage 4 if anyone wants to suggest something different. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13 (I think); cc @phoddie.
I'd welcome improvements to the wording here. Alternatively I could just link to Firefox's thoroughly commented implementation.