Skip to content

gpu: intel: document workaround for ocl compiler bug in sdpa ukernels #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

pv-pterab-s
Copy link
Contributor

Comment giving instruction on maneuvering around major OpenCL compiler bug when working with SDPA ukernel. Debugging is very difficult without this hint.

@pv-pterab-s pv-pterab-s requested a review from a team as a code owner March 19, 2025 16:18
@github-actions github-actions bot added the platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel label Mar 19, 2025
@pv-pterab-s pv-pterab-s changed the title gpu:intel: doc workaround for ocl compiler bug in sdpa ukernels gpu: intel: doc workaround for ocl compiler bug in sdpa ukernels Mar 19, 2025
@pv-pterab-s pv-pterab-s force-pushed the pryorgal/sdpa_hint_comment branch from db6dd48 to 97cdf59 Compare March 19, 2025 16:27
@umar456
Copy link
Contributor

umar456 commented Mar 20, 2025

I don't see the value in this comment because we are using the results of the microkernel.

@pv-pterab-s
Copy link
Contributor Author

I don't see the value in this comment because we are using the results of the microkernel.

This is directive from Konstantin. Whenever working with this kernel, unused variables will eventually pop up even in the most unanticipated ways. Had I known this workaround from Peter, tons of time debugging would have been saved. I suggested a wiki page or note, but he wants it in the code instead.

@karturov
Copy link
Contributor

I don't see the value in this comment because we are using the results of the microkernel.

This is directive from Konstantin. Whenever working with this kernel, unused variables will eventually pop up even in the most unanticipated ways. Had I known this workaround from Peter, tons of time debugging would have been saved. I suggested a wiki page or note, but he wants it in the code instead.

Do we have a bug tracker documenting this OpenCL compiler bug?

@pv-pterab-s pv-pterab-s changed the title gpu: intel: doc workaround for ocl compiler bug in sdpa ukernels gpu: intel: document workaround for ocl compiler bug in sdpa ukernels Jun 11, 2025
@pv-pterab-s pv-pterab-s merged commit 8b485fb into main Jun 13, 2025
14 checks passed
@pv-pterab-s pv-pterab-s deleted the pryorgal/sdpa_hint_comment branch June 13, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants