Skip to content

generic: sycl: RNN Vanilla BWD #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

generic: sycl: RNN Vanilla BWD #3015

merged 2 commits into from
Jun 16, 2025

Conversation

ShanoToni
Copy link
Contributor

Description

Extending generic SYCL implementation of RNN to support backpropagation of vanilla cell.

Fixes # (github issue)

Checklist

General

  • [ x ] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • [ x ] Have you formatted the code using clang-format?

@ShanoToni ShanoToni requested review from a team as code owners April 3, 2025 15:17
@github-actions github-actions bot added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Apr 3, 2025
@ShanoToni ShanoToni requested a review from a team as a code owner April 3, 2025 15:20
@github-actions github-actions bot added the component:graph-api Codeowner: @oneapi-src/onednn-graph label Apr 3, 2025
@ShanoToni
Copy link
Contributor Author

make test
disable build_vendor_intel
disable test_device_cpu
enable build_vendor_generic
enable arch_gpu_ampere
enable compiler_icx-oss

TaoLv
TaoLv reviewed Apr 4, 2025
View reviewed changes
src/graph/utils/sycl_check.hpp Outdated
@@ -0,0 +1,46 @@
/*******************************************************************************
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to add this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it was not. Thank you for pointing this out, I have removed the change. (I believe this might have been a earlier rebase artefact)

@github-actions github-actions bot removed the component:graph-api Codeowner: @oneapi-src/onednn-graph label Apr 4, 2025
AD2605
AD2605 reviewed Apr 15, 2025
View reviewed changes
@ShanoToni
Copy link
Contributor Author

make test
disable build_vendor_intel
disable test_device_cpu
enable build_vendor_generic
enable arch_gpu_ampere
enable compiler_icx-oss

mgouicem
mgouicem reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@mgouicem mgouicem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. A few remarks

  • commit name: maybe sycl:generic: add vanilla rnn bwd support
  • (nit) please split fixes to forward, do_copy and bias handling from adding backward? Would make diffs simpler to read and would help when checking history of changes when debugging

@ShanoToni ShanoToni force-pushed the rnn_vanilla_bwd branch 3 times, most recently from c24fc3a to e03f97c Compare June 6, 2025 16:26
@ShanoToni
Copy link
Contributor Author

@mgouicem Thank you for the comments, commit name has been changed as per your suggestion, and the PR has been split between refactoring forward RNN and additon of backwards, I hope it makes it clearer.

mgouicem
mgouicem reviewed Jun 12, 2025
View reviewed changes
@ShanoToni
Copy link
Contributor Author

make test
disable build_vendor_intel
disable test_device_cpu
enable build_vendor_generic
enable arch_gpu_ampere
enable compiler_icx-oss

@ShanoToni ShanoToni merged commit 720617c into uxlfoundation:main Jun 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoLv TaoLv TaoLv left review comments

@mgouicem mgouicem mgouicem approved these changes

@AD2605 AD2605 AD2605 approved these changes

Assignees
No one assigned
Labels
component:common platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShanoToni @TaoLv @mgouicem @AD2605