xbyak: allow repeated assignment of the same opmask index #3407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
densamoilov
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change relaxes the opmask assignment check in
setOpmaskIdxto allow setting the same opmask index multiple times on a Xbyak register, instead of throwing an exception on any repeated assignment.Previously, assigning an opmask index that was already set would always result in a runtime error. With this update, an exception is only thrown if a different opmask index is assigned.
This behavior was problematic in scenarios where the same opmask might be set more than once during JIT code generation, such as when handling binary post-ops with tail processing and comparison operations.
Addresses MFDNN-7033
The change has been upstreamed to Xbyak: herumi/xbyak#209