graph: handle different engine instances in compied parition cache #3413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyhintel
force-pushed
the
gyh/main/cp_eigine
branch
from
ea29874 to
2ff64a5
Compare
|
make test |
ElaineBao
reviewed
Jun 17, 2025
| @@ -97,6 +97,10 @@ struct sdp_primitive_kernel_t : public kernel_base_t { | |||
|
|
|||
| DEF_KERNEL_METHOD_STR(sdp_primitive_kernel_t) | |||
| DNNL_DISALLOW_COPY_AND_ASSIGN(sdp_primitive_kernel_t) | |||
| status_t reset_engine(const engine_t *g_engine) override { | |||
| UNUSED(g_engine); | |||
There was a problem hiding this comment.
For sdp_primitive_kernel_t, the executable object is primitive_tL70. For primitive_t object, there is no engine in this object. So we don't need to reset engine for it.
gyhintel
force-pushed
the
gyh/main/cp_eigine
branch
from
2ff64a5 to
6ebe88b
Compare
|
make test |
TaoLv
reviewed
Jun 17, 2025
| @@ -113,7 +113,7 @@ status_t dnnl_partition_impl_t::compile( | |||
| compiled_partition_t *compiled_partition, | |||
| const std::vector<logical_tensor_t> &inputs, | |||
| const std::vector<logical_tensor_t> &outputs, | |||
| const engine_t *g_engine) const { | |||
| engine_t *g_engine) const { | |||
There was a problem hiding this comment.
What does this mean? We do have a const engine in the public compile API. I assume that const-ness will propagate from API to internal implementations.
| @@ -91,6 +91,7 @@ struct batch_norm_fwd_t : public kernel_base_t { | |||
|
|
|||
| DEF_KERNEL_METHOD_STR(batch_norm_fwd_t) | |||
| DNNL_DISALLOW_COPY_AND_ASSIGN(batch_norm_fwd_t) | |||
| KERNEL_RESET_ENGINE | |||
There was a problem hiding this comment.
Suggested change
| KERNEL_RESET_ENGINE | |
| DEF_KERNEL_METHOD_RESET_ENGINE |
Just try to align with the name of DEF_KERNEL_METHOD_STR.
gyhintel
force-pushed
the
gyh/main/cp_eigine
branch
from
6ebe88b to
06880e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix MFDNN-12121
In this PR, we add the
reset_enginemethod to reset the compiled partition's and kernel's engine. With this PR, the compiled partition and primitive cache can be hit for different engine cases (Same member functions and member variables)