Skip to content

graph: backend: dnnl: fix genindex for threadpool runtime #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

gyhintel
Copy link
Contributor

Description

Added the stream hook to fix the genindex implementation for threadpool runtime.

@gyhintel gyhintel self-assigned this Jun 11, 2025
@gyhintel gyhintel requested a review from a team as a code owner June 11, 2025 09:03
@gyhintel gyhintel added the component:graph-api Codeowner: @oneapi-src/onednn-graph label Jun 11, 2025
Comment on lines +1837 to +1838

stream.get()->before_exec_hook();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is CPU_RUNTIME macro check for threadpool runtime needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should not need to check CPU_RUNTIME macro. The before_exec_hook and after_exec_hook are virtual functions. It would call the function in derived-class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I was thinking that this exec_hook is only added for the threadpool runtime. Thanks~

@gyhintel
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@TaoLv
Copy link
Contributor

TaoLv commented Jun 17, 2025

@gyhintel can you please trigger a pre-ci with threadpool runtime enabled?

@gyhintel
Copy link
Contributor Author

Okay, I will trigger a pre-ci with threadpool runtime.

@gyhintel
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph
enable build_cpu_runtime_thrpool_eigen

@TaoLv TaoLv merged commit 409add8 into main Jun 20, 2025
12 of 13 checks passed
@TaoLv TaoLv deleted the gyh/main/fix-genindex branch June 20, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:graph-api Codeowner: @oneapi-src/onednn-graph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants