[backport][rls-v3.8] cpu: x64: matmul: fix blocking heuristics for l2 set issues #3436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform:cpu-x64
yair-obodovsky
force-pushed
the
yobodovs/l2-fix-port
branch
from
5f58eb0 to
2f34b95
Compare
|
make test |
yair-obodovsky
force-pushed
the
yobodovs/l2-fix-port
branch
from
2f34b95 to
15d3fc2
Compare
mgouicem
reviewed
Jun 17, 2025
| // The following consts are correct for all platforms supporting AMX | ||
| constexpr size_t l2_ways = 16; | ||
| constexpr size_t l2_ways_threshold = size_t(l2_ways * 0.75); | ||
| constexpr size_t l2_sets = 2048; |
There was a problem hiding this comment.
Isn't number_of_sets = cache_size / number_ways ?
There was a problem hiding this comment.
fixed implemented in new function in platform.cpp:
uint32_t get_num_ways_in_cache(int level)
uint32_t get_num_sets_in_cache(int level)
and used them in heuristics.
There was a problem hiding this comment.
My bad I missed it was a backport. I guess you could just backport the original changes from main in this PR, and put these extra changes (query cache ways in xbyak_utils) to main in another PR.
yair-obodovsky
force-pushed
the
yobodovs/l2-fix-port
branch
from
15d3fc2 to
ad81169
Compare
yair-obodovsky
force-pushed
the
yobodovs/l2-fix-port
branch
from
ad81169 to
5169c5b
Compare
dzarukin
changed the title
ankalinin
approved these changes
Jun 18, 2025
densamoilov
approved these changes
Jun 18, 2025
|
make test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix performance degradation related to issue:
https://jira.devtools.intel.com/browse/MFDNN-13324
backport original pull request:
#3403