Skip to content

[GPU] Add Root Mean Square (RMS) normalization support to lnorm #3438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[GPU] Add Root Mean Square (RMS) normalization support to lnorm #3438

wants to merge 4 commits into from

Conversation

yehudaorel
Copy link
Contributor

Implements: https://jira.devtools.intel.com/browse/MFDNN-13581

  • Added GPU support for RMS normalization in layer norm.
  • Added skip_mean bool parameter to invoke RMS.
  • Extended testing [gtests & benchdnn] with GPU cases.

Following: #3068

@yehudaorel yehudaorel requested review from a team as code owners June 17, 2025 16:27
@github-actions github-actions bot added platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel component:tests Codeowner: @oneapi-src/onednn-arch labels Jun 17, 2025
mzhukova
mzhukova reviewed Jun 17, 2025
View reviewed changes
@yehudaorel yehudaorel requested a review from a team as a code owner June 17, 2025 17:28
@github-actions github-actions bot added the platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic label Jun 17, 2025
@ShanoToni
Copy link
Contributor

make test
disable build_vendor_intel
disable build_vendor_intel
disable test_device_cpu
enable build_vendor_generic
enable arch_gpu_ampere
enable compiler_icx-oss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzhukova mzhukova mzhukova left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
component:tests Codeowner: @oneapi-src/onednn-arch platform:gpu-generic Codeowner: @oneapi-src/onednn-gpu-generic platform:gpu-intel Codeowner: @oneapi-src/onednn-gpu-intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yehudaorel @ShanoToni @mzhukova