Skip to content

Commit 717584a

Browse files
SergeyKopienkoSergeyKopienko
committed
Mark lambdas for move out in tests
// KSATODO need move out
1 parent c4c3ff1 commit 717584a

19 files changed

+52
-52
lines changed

‎test/general/sycl_iterator/sycl_iterator_find.pass.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -327,48 +327,48 @@ DEFINE_TEST(test_any_all_none_of)
327327
if (n == 1)
328328
{
329329
auto res0 = ::std::any_of(CREATE_NEW_POLICY(exec, 0), first1, first1,
330-
[n](T1 x) { return x == n - 1; });
330+
[n](T1 x) { return x == n - 1; }); // KSATODO need move out
331331
wait_and_throw(exec);
332332

333333
EXPECT_TRUE(!res0, "wrong effect from any_of_0");
334334
res0 = ::std::none_of(CREATE_NEW_POLICY(exec, 1), first1, first1,
335-
[](T1 x) { return x == -1; });
335+
[](T1 x) { return x == -1; }); // KSATODO need move out
336336
wait_and_throw(exec);
337337

338338
EXPECT_TRUE(res0, "wrong effect from none_of_0");
339339
res0 = ::std::all_of(CREATE_NEW_POLICY(exec, 2), first1, first1,
340-
[](T1 x) { return x % 2 == 0; });
340+
[](T1 x) { return x % 2 == 0; }); // KSATODO need move out
341341
wait_and_throw(exec);
342342

343343
EXPECT_TRUE(res0, "wrong effect from all_of_0");
344344
}
345345
// any_of
346346
auto res1 = ::std::any_of(CREATE_NEW_POLICY(exec, 3), first1, last1,
347-
[n](T1 x) { return x == n - 1; });
347+
[n](T1 x) { return x == n - 1; }); // KSATODO need move out
348348
wait_and_throw(exec);
349349

350350
EXPECT_TRUE(res1, "wrong effect from any_of_1");
351351
auto res2 = ::std::any_of(CREATE_NEW_POLICY(exec, 4), first1, last1,
352-
[](T1 x) { return x == -1; });
352+
[](T1 x) { return x == -1; }); // KSATODO need move out
353353
wait_and_throw(exec);
354354

355355
EXPECT_TRUE(!res2, "wrong effect from any_of_2");
356356
auto res3 = ::std::any_of(CREATE_NEW_POLICY(exec, 5), first1, last1,
357-
[](T1 x) { return x % 2 == 0; });
357+
[](T1 x) { return x % 2 == 0; }); // KSATODO need move out
358358
wait_and_throw(exec);
359359

360360
EXPECT_TRUE(res3, "wrong effect from any_of_3");
361361

362362
//none_of
363363
auto res4 = ::std::none_of(CREATE_NEW_POLICY(exec, 6), first1, last1,
364-
[](T1 x) { return x == -1; });
364+
[](T1 x) { return x == -1; }); // KSATODO need move out
365365
wait_and_throw(exec);
366366

367367
EXPECT_TRUE(res4, "wrong effect from none_of");
368368

369369
//all_of
370370
auto res5 = ::std::all_of(CREATE_NEW_POLICY(exec, 7), first1, last1,
371-
[](T1 x) { return x % 2 == 0; });
371+
[](T1 x) { return x % 2 == 0; }); // KSATODO need move out
372372
wait_and_throw(exec);
373373

374374
EXPECT_TRUE(n == 1 || !res5, "wrong effect from all_of");
@@ -394,7 +394,7 @@ DEFINE_TEST(test_find_if)
394394
if (n == 1)
395395
{
396396
auto res0 = ::std::find_if(CREATE_NEW_POLICY(exec, 0), first1, first1,
397-
[n](T1 x) { return x == n - 1; });
397+
[n](T1 x) { return x == n - 1; }); // KSATODO need move out
398398
wait_and_throw(exec);
399399

400400
EXPECT_TRUE(res0 == first1, "wrong effect from find_if_0");
@@ -405,19 +405,19 @@ DEFINE_TEST(test_find_if)
405405
}
406406
// find_if
407407
auto res1 = ::std::find_if(CREATE_NEW_POLICY(exec, 2), first1, last1,
408-
[n](T1 x) { return x == n - 1; });
408+
[n](T1 x) { return x == n - 1; }); // KSATODO need move out
409409
wait_and_throw(exec);
410410

411411
EXPECT_TRUE((res1 - first1) == n - 1, "wrong effect from find_if_1");
412412

413413
auto res2 = ::std::find_if(CREATE_NEW_POLICY(exec, 3), first1, last1,
414-
[](T1 x) { return x == -1; });
414+
[](T1 x) { return x == -1; }); // KSATODO need move out
415415
wait_and_throw(exec);
416416

417417
EXPECT_TRUE(res2 == last1, "wrong effect from find_if_2");
418418

419419
auto res3 = ::std::find_if(CREATE_NEW_POLICY(exec, 4), first1, last1,
420-
[](T1 x) { return x % 2 == 0; });
420+
[](T1 x) { return x % 2 == 0; }); // KSATODO need move out
421421
wait_and_throw(exec);
422422

423423
EXPECT_TRUE(res3 == first1, "wrong effect from find_if_3");

‎test/general/sycl_iterator/sycl_iterator_for.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,7 @@ DEFINE_TEST(test_adjacent_difference)
982982
Iterator1ValueType fill_value{1};
983983
Iterator2ValueType blank_value{0};
984984

985-
auto __f = [](Iterator1ValueType& a, Iterator1ValueType& b) -> Iterator2ValueType { return a + b; };
985+
auto __f = [](Iterator1ValueType& a, Iterator1ValueType& b) -> Iterator2ValueType { return a + b; }; // KSATODO need move out
986986

987987
// init
988988
::std::for_each(host_keys.get(), host_keys.get() + n,

‎test/general/sycl_iterator/sycl_iterator_reduce.pass.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ DEFINE_TEST(test_count_if)
279279
// check when arbitrary should be counted
280280
ReturnType expected = (n - 1) / 10 + 1;
281281
ReturnType result = ::std::count_if(CREATE_NEW_POLICY(exec, 0), first, last,
282-
[](ValueType const& value) { return value % 10 == 0; });
282+
[](ValueType const& value) { return value % 10 == 0; }); // KSATODO need move out
283283
wait_and_throw(exec);
284284

285285
EXPECT_TRUE(result == expected, "wrong effect from count_if (Test #1 arbitrary to count)");
@@ -290,7 +290,7 @@ DEFINE_TEST(test_count_if)
290290
// check when none should be counted
291291
expected = 0;
292292
result = ::std::count_if(CREATE_NEW_POLICY(exec, 1), first, last,
293-
[](ValueType const& value) { return value > 10; });
293+
[](ValueType const& value) { return value > 10; }); // KSATODO need move out
294294
wait_and_throw(exec);
295295

296296
EXPECT_TRUE(result == expected, "wrong effect from count_if (Test #2 none to count)");
@@ -301,7 +301,7 @@ DEFINE_TEST(test_count_if)
301301
// check when all should be counted
302302
expected = n;
303303
result = ::std::count_if(CREATE_NEW_POLICY(exec, 2), first, last,
304-
[](ValueType const& value) { return value < 10; });
304+
[](ValueType const& value) { return value < 10; }); // KSATODO need move out
305305
wait_and_throw(exec);
306306

307307
EXPECT_TRUE(result == expected, "wrong effect from count_if (Test #3 all to count)");

‎test/general/sycl_iterator/sycl_iterator_scan.pass.cpp

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ DEFINE_TEST(test_remove_if)
8484

8585
auto pos = (last - first) / 2;
8686
auto res1 = ::std::remove_if(CREATE_NEW_POLICY(exec, 0), first, last,
87-
[=](T1 x) { return x == T1(222 + pos); });
87+
[=](T1 x) { return x == T1(222 + pos); }); // KSATODO need move out
8888
wait_and_throw(exec);
8989

9090
EXPECT_TRUE(res1 == last - 1, "wrong result from remove_if");
@@ -123,7 +123,7 @@ DEFINE_TEST(test_unique)
123123
host_keys.update_data();
124124

125125
// invoke
126-
auto f = [](IteratorValueType a, IteratorValueType b) { return a == b; };
126+
auto f = [](IteratorValueType a, IteratorValueType b) { return a == b; }; // KSATODO need move out
127127
auto result_last = ::std::unique(CREATE_NEW_POLICY(exec, 0), first, last, f);
128128
wait_and_throw(exec);
129129

@@ -172,7 +172,7 @@ DEFINE_TEST(test_partition)
172172
host_keys.update_data();
173173

174174
// invoke partition
175-
auto unary_op = [](IteratorValueType value) { return (value % 3 == 0) && (value % 2 == 0); };
175+
auto unary_op = [](IteratorValueType value) { return (value % 3 == 0) && (value % 2 == 0); }; // KSATODO need move out
176176
auto res = ::std::partition(CREATE_NEW_POLICY(exec, 0), first, last, unary_op);
177177
wait_and_throw(exec);
178178

@@ -217,7 +217,7 @@ DEFINE_TEST(test_transform_inclusive_scan)
217217

218218
auto res1 = ::std::transform_inclusive_scan(
219219
CREATE_NEW_POLICY(exec, 0), first1, last1, first2, ::std::plus<T1>(),
220-
[](T1 x) { return x * 2; }, value);
220+
[](T1 x) { return x * 2; }, value); // KSATODO need move out
221221
wait_and_throw(exec);
222222

223223
EXPECT_TRUE(res1 == last2, "wrong result from transform_inclusive_scan_1");
@@ -238,7 +238,7 @@ DEFINE_TEST(test_transform_inclusive_scan)
238238

239239
// without initial value
240240
auto res2 = ::std::transform_inclusive_scan(CREATE_NEW_POLICY(exec, 1), first1, last1,
241-
first2, ::std::plus<T1>(), [](T1 x) { return x * 2; });
241+
first2, ::std::plus<T1>(), [](T1 x) { return x * 2; }); // KSATODO need move out
242242
EXPECT_TRUE(res2 == last2, "wrong result from transform_inclusive_scan_2");
243243

244244
retrieve_data(host_keys, host_vals);
@@ -275,7 +275,7 @@ DEFINE_TEST(test_transform_exclusive_scan)
275275

276276
auto res1 =
277277
::std::transform_exclusive_scan(CREATE_NEW_POLICY(exec, 2), first1, last1, first2,
278-
T1{}, ::std::plus<T1>(), [](T1 x) { return x * 2; });
278+
T1{}, ::std::plus<T1>(), [](T1 x) { return x * 2; }); // KSATODO need move out
279279
wait_and_throw(exec);
280280

281281
EXPECT_TRUE(res1 == last2, "wrong result from transform_exclusive_scan");
@@ -312,7 +312,7 @@ DEFINE_TEST(test_copy_if)
312312
host_keys.update_data();
313313

314314
auto res1 = ::std::copy_if(CREATE_NEW_POLICY(exec, 0), first1, last1, first2,
315-
[](T1 x) { return x > -1; });
315+
[](T1 x) { return x > -1; }); // KSATODO need move out
316316
wait_and_throw(exec);
317317

318318
EXPECT_TRUE(res1 == last2, "wrong result from copy_if_1");
@@ -330,7 +330,7 @@ DEFINE_TEST(test_copy_if)
330330
}
331331

332332
auto res2 = ::std::copy_if(CREATE_NEW_POLICY(exec, 1), first1, last1, first2,
333-
[](T1 x) { return x % 2 == 1; });
333+
[](T1 x) { return x % 2 == 1; }); // KSATODO need move out
334334
wait_and_throw(exec);
335335

336336
EXPECT_TRUE(res2 == first2 + (last2 - first2) / 2, "wrong result from copy_if_2");
@@ -369,7 +369,7 @@ DEFINE_TEST(test_unique_copy)
369369
update_data(host_keys, host_vals);
370370

371371
// invoke
372-
auto f = [](Iterator1ValueType a, Iterator1ValueType b) { return a == b; };
372+
auto f = [](Iterator1ValueType a, Iterator1ValueType b) { return a == b; }; // KSATODO need move out
373373
auto result_first = first2;
374374
auto result_last =
375375
::std::unique_copy(CREATE_NEW_POLICY(exec, 0), first1, last1, result_first, f);
@@ -418,7 +418,7 @@ DEFINE_TEST(test_partition_copy)
418418
using Iterator1ValueType = typename ::std::iterator_traits<Iterator1>::value_type;
419419
using Iterator2ValueType = typename ::std::iterator_traits<Iterator2>::value_type;
420420
using Iterator3ValueType = typename ::std::iterator_traits<Iterator3>::value_type;
421-
auto f = [](Iterator1ValueType value) { return (value % 3 == 0) && (value % 2 == 0); };
421+
auto f = [](Iterator1ValueType value) { return (value % 3 == 0) && (value % 2 == 0); }; // KSATODO need move out
422422

423423
// init
424424
::std::iota(host_keys.get(), host_keys.get() + n, Iterator1ValueType{0});

‎test/parallel_api/algorithm/alg.sorting/alg.binary.search/binary.search/binary_search.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ DEFINE_TEST(test_binary_search)
8282

8383
// call algorithm with comparator
8484
auto res2 = oneapi::dpl::binary_search(CREATE_NEW_POLICY(exec, 1), first, last, value_first, value_last, result_first,
85-
[](ValueT first, ValueT second) { return first < second; });
85+
[](ValueT first, ValueT second) { return first < second; }); // KSATODO need move out
8686
exec.queue().wait_and_throw();
8787

8888
EXPECT_TRUE(std::distance(result_first, res2) == n, "wrong return value, with predicate, device policy");

‎test/parallel_api/algorithm/alg.sorting/alg.binary.search/lower.bound/lower_bound.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ DEFINE_TEST(test_lower_bound)
7777

7878
// call algorithm with comparator
7979
auto res2 = oneapi::dpl::lower_bound(CREATE_NEW_POLICY(exec, 1), first, last, value_first, value_last, result_first,
80-
[](ValueT first, ValueT second) { return first < second; });
80+
[](ValueT first, ValueT second) { return first < second; }); // KSATODO need move out
8181
exec.queue().wait_and_throw();
8282

8383
EXPECT_TRUE(std::distance(result_first, res2) == n, "wrong return value, with predicate, device policy");

‎test/parallel_api/algorithm/alg.sorting/alg.binary.search/upper.bound/upper_bound.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ DEFINE_TEST(test_upper_bound)
8484

8585
// call algorithm with comparator
8686
auto res2 = oneapi::dpl::upper_bound(CREATE_NEW_POLICY(exec, 1), first, last, value_first, value_last, result_first,
87-
[](ValueT first, ValueT second) { return first < second; });
87+
[](ValueT first, ValueT second) { return first < second; }); // KSATODO need move out
8888
exec.queue().wait_and_throw();
8989

9090
EXPECT_TRUE(std::distance(result_first, res2) == n, "wrong return value, with predicate, device policy");

‎test/parallel_api/iterator/zip_iterator_equal.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ DEFINE_TEST(test_equal_structured_binding)
111111
"zip_iterator (equal_structured_binding2) not properly copyable");
112112
}
113113

114-
auto compare = [](auto tuple_first1, auto tuple_first2)
114+
auto compare = [](auto tuple_first1, auto tuple_first2) // KSATODO need move out
115115
{
116116
const auto& [a, b] = tuple_first1;
117117
const auto& [c, d] = tuple_first2;

‎test/parallel_api/iterator/zip_iterator_find.pass.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,9 @@ DEFINE_TEST(test_find_if)
5555
EXPECT_TRUE(sycl::is_device_copyable_v<decltype(tuple_first1)>, "zip_iterator (find_if) not properly copyable");
5656
}
5757

58-
auto f_for_last = [n](T1 x) { return x == n - 1; };
59-
auto f_for_none = [](T1 x) { return x == -1; };
60-
auto f_for_first = [](T1 x) { return x % 2 == 0; };
58+
auto f_for_last = [n](T1 x) { return x == n - 1; }; // KSATODO need move out
59+
auto f_for_none = [](T1 x) { return x == -1; }; // KSATODO need move out
60+
auto f_for_first = [](T1 x) { return x % 2 == 0; }; // KSATODO need move out
6161

6262
auto tuple_res1 = std::find_if(CREATE_NEW_POLICY(exec, 0), tuple_first1, tuple_last1,
6363
TuplePredicate<decltype(f_for_last), 0>{f_for_last});

‎test/parallel_api/iterator/zip_iterator_for.pass.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ DEFINE_TEST(test_for_each)
4444
typedef typename std::iterator_traits<Iterator1>::value_type T1;
4545

4646
auto value = T1(6);
47-
auto f = [](T1& val) { ++val; };
47+
auto f = [](T1& val) { ++val; }; // KSATODO need move out
4848
std::fill(host_keys.get(), host_keys.get() + n, value);
4949
host_keys.update_data();
5050

@@ -95,7 +95,7 @@ DEFINE_TEST(test_for_each_structured_binding)
9595
}
9696

9797
std::for_each(CREATE_NEW_POLICY(exec, 0), tuple_first1, tuple_last1,
98-
[f](auto value)
98+
[f](auto value) // KSATODO need move out
9999
{
100100
auto [x, y] = value;
101101
f(x);

‎test/parallel_api/iterator/zip_iterator_scan.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ DEFINE_TEST(test_counting_zip_transform)
210210
auto res =
211211
std::copy_if(CREATE_NEW_POLICY(exec, 0), start, start + n,
212212
oneapi::dpl::make_transform_iterator(first2,
213-
[](ValueType& x1)
213+
[](ValueType& x1) // KSATODO need move out
214214
{
215215
// It's required to use forward_as_tuple instead of make_tuple
216216
// as the latter do not propagate references.

‎test/parallel_api/ranges/adjacent_find_ranges_sycl.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ void test(Policy&& exec)
4242
sycl::buffer<int> A(data, sycl::range<1>(n));
4343

4444
res1 = adjacent_find(CREATE_NEW_POLICY(exec, 0), views::all_read(A));
45-
res2 = adjacent_find(CREATE_NEW_POLICY(exec, 1), A, [](auto a, auto b) {return a == b;});
45+
res2 = adjacent_find(CREATE_NEW_POLICY(exec, 1), A, [](auto a, auto b) {return a == b;}); // KSATODO need move out
4646
}
4747

4848
//check result

‎test/parallel_api/ranges/find_ranges_sycl.pass.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@ main()
5151

5252
res1 = find(CREATE_NEW_POLICY(exec, 0), view, val); //check passing all_view
5353
res1 = find(CREATE_NEW_POLICY(exec, 1), A, val); //check passing sycl::buffer directly
54-
res2 = find_if(CREATE_NEW_POLICY(exec, 2), view, [val](auto a) { return a == val;});
55-
res2 = find_if(CREATE_NEW_POLICY(exec, 3), A, [val](auto a) { return a == val;});
56-
res3 = find_if_not(CREATE_NEW_POLICY(exec, 4), view, [](auto a) { return a >= 0;});
57-
res3 = find_if_not(CREATE_NEW_POLICY(exec, 5), A, [](auto a) { return a >= 0;});
54+
res2 = find_if(CREATE_NEW_POLICY(exec, 2), view, [val](auto a) { return a == val;}); // KSATODO need move out
55+
res2 = find_if(CREATE_NEW_POLICY(exec, 3), A, [val](auto a) { return a == val;}); // KSATODO need move out
56+
res3 = find_if_not(CREATE_NEW_POLICY(exec, 4), view, [](auto a) { return a >= 0;}); // KSATODO need move out
57+
res3 = find_if_not(CREATE_NEW_POLICY(exec, 5), A, [](auto a) { return a >= 0;}); // KSATODO need move out
5858
}
5959

6060
//check result

‎test/parallel_api/ranges/is_sorted_ranges_sycl.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ main()
4848

4949
res1 = is_sorted(exec, all_view(A));
5050
res2 = is_sorted(CREATE_NEW_POLICY(exec, 0), B);
51-
res3 = is_sorted(CREATE_NEW_POLICY(exec, 1), A, [](auto a, auto b) { return a > b;});
51+
res3 = is_sorted(CREATE_NEW_POLICY(exec, 1), A, [](auto a, auto b) { return a > b;}); // KSATODO need move out
5252
}
5353

5454
//check result

‎test/parallel_api/ranges/is_sorted_until_ranges_sycl.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ main()
4848
using Policy = decltype(TestUtils::default_dpcpp_policy);
4949

5050
res1 = is_sorted_until(exec, view);
51-
res2 = is_sorted_until(CREATE_NEW_POLICY(exec, 0), A, [](auto a, auto b) { return a < b; });
51+
res2 = is_sorted_until(CREATE_NEW_POLICY(exec, 0), A, [](auto a, auto b) { return a < b; }); // KSATODO need move out
5252
}
5353

5454
//check result

‎test/parallel_api/ranges/search_ranges_sycl.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ main()
5252
using Policy = decltype(TestUtils::default_dpcpp_policy);
5353

5454
res1 = search(exec, A, view_b);
55-
res2 = search(CREATE_NEW_POLICY(exec, 0), view_a, B, [](auto a, auto b) { return a == b; });
55+
res2 = search(CREATE_NEW_POLICY(exec, 0), view_a, B, [](auto a, auto b) { return a == b; }); // KSATODO need move out
5656
}
5757

5858
//check result

‎test/parallel_api/ranges/sort_ranges_sycl.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ main()
7777
B.set_write_back(true);
7878

7979
sort(CREATE_NEW_POLICY(exec, 1), zip_view(views::all(A), views::all(B)), ::std::less{},
80-
[](const auto& a) { return ::std::get<1>(a); });
80+
[](const auto& a) { return ::std::get<1>(a); }); // KSATODO need move out
8181
}
8282
bool res3 = ::std::is_sorted(values.begin(), values.end(), ::std::less{});
8383
EXPECT_TRUE(res3, "wrong effect from 'sort by key'");

0 commit comments

Comments
 (0)